Skip to content

Enable cross OS DBI build - #35021

Merged
sdmaclea merged 5 commits into
dotnet:masterfrom
sdmaclea:crossDBI
Apr 17, 2020
Merged

Enable cross OS DBI build#35021
sdmaclea merged 5 commits into
dotnet:masterfrom
sdmaclea:crossDBI

Conversation

@sdmaclea

Copy link
Copy Markdown
Contributor

No description provided.

@sdmaclea sdmaclea added this to the 5.0 milestone Apr 15, 2020
@sdmaclea
sdmaclea requested review from hoyosjs and mikem8361 April 15, 2020 20:27
@sdmaclea sdmaclea self-assigned this Apr 15, 2020
@ghost

ghost commented Apr 15, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

Comment thread src/coreclr/src/debug/debug-pal/dummy/twowaypipe.cpp Outdated
Comment thread src/coreclr/src/md/CMakeLists.txt Outdated
@hoyosjs

hoyosjs commented Apr 16, 2020

Copy link
Copy Markdown
Member

Also, does this require any build script changes?

@sdmaclea

sdmaclea commented Apr 16, 2020

Copy link
Copy Markdown
Contributor Author

Also, does this require any build script changes?

Not at the moment. The Cross DBI will be built with the Cross DAC.

It will require changes to the packages and signing which you are drafting.

@sdmaclea sdmaclea closed this Apr 16, 2020
@sdmaclea sdmaclea reopened this Apr 16, 2020
@ghost

ghost commented Apr 17, 2020

Copy link
Copy Markdown

Hello @sdmaclea!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@sdmaclea
sdmaclea merged commit 9890a9a into dotnet:master Apr 17, 2020
@sdmaclea
sdmaclea deleted the crossDBI branch April 17, 2020 19:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants